SAK-51126 Samigo remove legacy email and related code #13561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ottenhoff
commented
Apr 7, 2025
ottenhoff
commented
The SamigoEmailService, EmailBean, and related email functionality was a legacy feature that has been replaced by the simpler mailto links approach in the current UI. This commit removes these unused components since they are no longer referenced in the UI flow. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Removed the remaining EmailListener class which is no longer used in the codebase. The email function has been superseded by the simpler mailto links in totalScores.jsp. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Removed the navigation rules for createNewEmail, confirmEmailSent, and emailError from faces-config.xml since the corresponding JSP files have been deleted. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ern
changed the title
ern
approved these changes
Apr 7, 2025
maurercw
reviewed
Apr 8, 2025
samigo/samigo-app/src/java/org/sakaiproject/jsf/util/SamigoJsfTool.java
Outdated
Show resolved
Hide resolved
ern
pushed a commit
that referenced
this pull request
Apr 10, 2025
(cherry picked from commit 8d48b44)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.